feat(NoBlockedMessages): Remove replies to blocked messages#4190
Draft
n1ckoates wants to merge 1 commit into
Draft
feat(NoBlockedMessages): Remove replies to blocked messages#4190n1ckoates wants to merge 1 commit into
n1ckoates wants to merge 1 commit into
Conversation
Contributor
|
From my experience just patching readstatestore and messagestore is absolutely enough to filter out replies, it's the first two patches, just put an or into the if and see if that works if you didn't already (worked fine for me the last time I worked on #3035) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4182
This is my first time writing patch regexes for Vencord, so hopefully I'm doing this right. Apologies if not.
I initially thought this would be a pretty simple task but it required a lot more code than I had anticipated.
nullif so.ReplyStoreto lookup message references, because messages being replied to often weren't inMessageStorein my testing, especially when they were old. So there's additional patches to get access toReplyStore.